Enable execution if non-ascii schema name #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chikamura
changed the title
|
Anonther PR also fixes an issue where embulk run fails when a non-ascii schema name is specified. The test code written in this PR was merged into the PR and a refactoring part was made into the separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix: if a non-ascii schema name is specified, an embulk run fails.
Change from an implementation that retrieves all cases by specifying null for database in tableIdentifier, the argument of getTables and getColumns, and filters the results with isAvailableTableMetadataInConnection to an implementation that sets connection default value for database in tableIdentifier.
See also:
embulk-output-databricks/src/main/java/org/embulk/output/databricks/DatabricksOutputConnection.java
Lines 48 to 55 in 478dfe0